Skip to content

Conversation

@binon
Copy link
Collaborator

@binon binon commented Feb 27, 2024

https://hee-tis.atlassian.net/browse/TD-2899

Description

Add an automated accessibility unit testing project to the LH web UI repository.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

…d_automated_accessibility_unit_testing_project
@binon
Copy link
Collaborator Author

binon commented Feb 27, 2024

There are some conflicts, so better create a new branch and create PR

@binon binon closed this Feb 27, 2024
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @binon. A few suggestions re StyleCop (we really need a dev team discussion about StyleCop soon). Also a query re scss fixes.

@binon binon reopened this Feb 28, 2024
@binon binon requested a review from kevwhitt-hee February 28, 2024 13:19
@binon binon merged commit 1f24c67 into release/accessibility Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants