-
Notifications
You must be signed in to change notification settings - Fork 1
Develop/features/td 2899 add automated accessibility unit testing project #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
binon
merged 6 commits into
release/accessibility
from
Develop/Features/TD-2899-add_automated_accessibility_unit_testing_project
Feb 28, 2024
Merged
Develop/features/td 2899 add automated accessibility unit testing project #154
binon
merged 6 commits into
release/accessibility
from
Develop/Features/TD-2899-add_automated_accessibility_unit_testing_project
Feb 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_automated_accessibility_unit_testing_project
|
There are some conflicts, so better create a new branch and create PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, @binon. A few suggestions re StyleCop (we really need a dev team discussion about StyleCop soon). Also a query re scss fixes.
LearningHub.Nhs.WebUI.AutomatedUiTests/AccessibilityTests/AccessibilityTestsBase.cs
Outdated
Show resolved
Hide resolved
LearningHub.Nhs.WebUI.AutomatedUiTests/AccessibilityTests/AccessibilityTestsBase.cs
Outdated
Show resolved
Hide resolved
LearningHub.Nhs.WebUI.AutomatedUiTests/AccessibilityTests/BasicAccessibilityTests.cs
Outdated
Show resolved
Hide resolved
LearningHub.Nhs.WebUI.AutomatedUiTests/AccessibilityTests/MyAccountAccessibiltyTests.cs
Outdated
Show resolved
Hide resolved
LearningHub.Nhs.WebUI.AutomatedUiTests/SeleniumServerFactory.cs
Outdated
Show resolved
Hide resolved
LearningHub.Nhs.WebUI.AutomatedUiTests/TestFixtures/AuthenticatedAccessibilityTestsFixture.cs
Outdated
Show resolved
Hide resolved
LearningHub.Nhs.WebUI.AutomatedUiTests/TestHelpers/ConfigurationHelper.cs
Outdated
Show resolved
Hide resolved
LearningHub.Nhs.WebUI.AutomatedUiTests/TestHelpers/DriverHelper.cs
Outdated
Show resolved
Hide resolved
LearningHub.Nhs.WebUI.AutomatedUiTests/TestHelpers/LoginHelper.cs
Outdated
Show resolved
Hide resolved
…sibility Release/accessibility
kevwhitt-hee
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hee-tis.atlassian.net/browse/TD-2899
Description
Add an automated accessibility unit testing project to the LH web UI repository.
Screenshots
Attach screenshots on mobile, tablet and desktop.
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: