Skip to content

Conversation

@AnjuJose011
Copy link
Contributor

JIRA link

TD-###

Description

Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

akdalin-hee and others added 16 commits March 14, 2024 09:42
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
This reverts commit 658632b.
…/TD-3675-Fix-Issues-UnknownError-ResourceDetailsPage

Develop/fixes/td 3675 fix issues unknown error resource details page
…/TD-3688-Missing-In-Progress-resources-in-the-My-Accessed-Learning-tray

TD-3688: Fixed missing In progress resources in the My Accessed Learning tray issue
…/TD-3726-Video-not-recording-progress-properly-and-returning-unknownerror

Develop/fixes/td 3726 video not recording progress properly and returning unknown error
…op/Fixes/TD-3726-Video-not-recording-progress-properly-and-returning-unknownerror"

This reverts commit 23732c2.
…/TD-3744-Jobrolewithslashincauseserrorduringregistration

TD-3744-Job role with slash in causes error during registration
…/TD-3881

TD-3881 stream audio or video file content within html resource
@AnjuJose011 AnjuJose011 changed the title Rc 14 03 2024 Merge Reticulum Changes to RC Mar 14, 2024
@AnjuJose011 AnjuJose011 merged commit 2b533ff into RC Mar 14, 2024
@AnjuJose011 AnjuJose011 deleted the RC-14-03-2024 branch March 14, 2024 15:11
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants