Skip to content

Conversation

@OluwatobiAwe
Copy link
Collaborator

@OluwatobiAwe OluwatobiAwe commented Jun 5, 2023

JIRA link

TD-1855

Description

Added optional CSS property to radiolist and checkboxes view components in other to even distribute child items horizontally in divs.
Added span with class="nhsuk-error-message" for validation error within the radiolist view component.

Screenshots

radio and checkbox


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@OluwatobiAwe OluwatobiAwe merged commit f4bcc85 into main Jun 5, 2023
@OluwatobiAwe OluwatobiAwe deleted the Develop/Fixes/TD-1855 branch July 26, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants