Skip to content

[Chore] Core Data Codegen을 Class Definition으로 변경하고 서브클래스 파일 삭제#29

Merged
jihyeonjjang merged 1 commit intodevfrom
feature/coreData-subClass-삭제
Jun 11, 2025

Hidden character warning

The head ref may contain hidden characters: "feature/coreData-subClass-\uc0ad\uc81c"
Merged

[Chore] Core Data Codegen을 Class Definition으로 변경하고 서브클래스 파일 삭제#29
jihyeonjjang merged 1 commit intodevfrom
feature/coreData-subClass-삭제

Conversation

@jihyeonjjang
Copy link
Copy Markdown
Collaborator

@jihyeonjjang jihyeonjjang commented Jun 11, 2025

변경 내용

  • .xcdatamodeld의 Codegen 설정을 Class Definition으로 변경
  • 수동으로 생성했던 NSManagedObject subclass 파일 제거
  • tags(NSSet?)는 사용 시 Set로 타입 캐스팅하여 처리

작업 목적

  • VideoEntity의 tags를 Set 타입으로 관리하고 싶어 subclass 생성 -> 불필요
  • tags를 사용할 때 type casting을 해서 사용하는 것으로 변경

- .xcdatamodeld의 Codegen 설정을 Class Definition으로 변경
- 수동으로 생성했던 NSManagedObject subclass 파일 제거
- tags(NSSet?)는 사용 시 Set<TagEntity>로 타입 캐스팅하여 처리
@korbit-ai
Copy link
Copy Markdown

korbit-ai Bot commented Jun 11, 2025

You've used up your 5 PR reviews for this month under the Korbit Starter Plan. You'll get 5 more reviews on June 22nd, 2025 or you can upgrade to Pro for unlimited PR reviews and enhanced features in your Korbit Console.

Copy link
Copy Markdown
Owner

@TeddKo TeddKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Copy Markdown
Collaborator

@giseungNoh giseungNoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

Copy link
Copy Markdown
Collaborator

@kdn0325 kdn0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@vinyl-nyl vinyl-nyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@jihyeonjjang jihyeonjjang merged commit 33572be into dev Jun 11, 2025
@jihyeonjjang jihyeonjjang deleted the feature/coreData-subClass-삭제 branch June 11, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants