Merged
Conversation
Collaborator
kdn0325
commented
Jun 11, 2025
kdn0325
commented
- APIClient 및 PixabayVideoService 싱글톤 의존 제거
- 의존성 주입 기반으로 설계 변경
- URLRequest 구성 분리 (Endpoint)
- 테스트 가능하고 확장성 높은 구조로 개선
…e/네트워크-서비스-싱글톤-패턴-제거
… creation and improve error handling
|
You've used up your 5 PR reviews for this month under the Korbit Starter Plan. You'll get 5 more reviews on June 22nd, 2025 or you can upgrade to Pro for unlimited PR reviews and enhanced features in your Korbit Console. |
…#36-network-di-refactor
jihyeonjjang
approved these changes
Jun 12, 2025
Collaborator
jihyeonjjang
left a comment
jihyeonjjang
left a comment
There was a problem hiding this comment.
엄청 멋진 네트워크 서비스가 되었네용!
kdn0325
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.