[Refactor] CoreDataManager 의존성 주입 전환 및 런치/탭바 구조 개선#39
Merged
jihyeonjjang merged 17 commits intodevfrom Jun 13, 2025
Merged
Conversation
- DIContainer를 통해 CoreDataManager와 PixabayVideoService 인스턴스를 주입 - LaunchScreenViewController와 TabBarViewController에 ViewModel 생성 및 주입 처리
- Info.plist에서 Main 스토리보드 제거 - SceneDelegate에서 DIContainer를 통해 LaunchScreenViewController 코드로 초기화 - LaunchScreenViewController UI를 코드로 재구성 - Main.storyboard에서 Launch 관련 뷰 제거 - LaunchScreen.storyboard에서 UI 요소 위치 및 크기 조정
… 기반 구조로 변경 - TabBarViewController가 CoreDataManager 대신 TabBarViewModel을 주입받도록 수정 - setupTabBar() 로직을 제거하고 viewModel에서 탭 구성 로직 위임
- 네트워크 및 CoreData 초기화 로직을 loadInitialData()로 이동 - performSegue 기반 화면 전환을 transitionToMain()로 대체 - LaunchScreenViewModel 생성 및 DI를 통한 초기화 구조 반영 - ViewModel에서 TabBarViewController 생성 책임 분리
- NSFetchedResultsController에 전달되는 fetchRequest에 sortDescriptors 설정
|
You've used up your 5 PR reviews for this month under the Korbit Starter Plan. You'll get 5 more reviews on June 22nd, 2025 or you can upgrade to Pro for unlimited PR reviews and enhanced features in your Korbit Console. |
jihyeonjjang
changed the title
- Home, Like, MyPage 탭의 ViewController를 코드 생성 → 스토리보드 기반으로 변경 (스토리보드를 유지하기 위함) - 각 ViewModel에 필요한 의존성(CoreDataManager, VideoService) 명시적으로 주입
- Home, Like, MyPage 스토리보드 객체와 VC 인스턴스 생성 로직 분리 - ViewModel 주입 부분은 추후 작업을 위해 주석 처리 상태로 유지
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
목적