Feature/home view extraheight fix#49
Merged
giseungNoh merged 3 commits intodevfrom Jun 13, 2025
Merged
Conversation
|
You've used up your 5 PR reviews for this month under the Korbit Starter Plan. You'll get 5 more reviews on June 22nd, 2025 or you can upgrade to Pro for unlimited PR reviews and enhanced features in your Korbit Console. |
Comment on lines
+114
to
+117
| let userImageHeight = itemWidth / 5 // 유저 이미지높이는 전체 셀 너비의 20퍼센트로 설정 | ||
| let totalHeight = thumbnailHeight + userImageHeight + spacingBetweenViews | ||
|
|
||
| return CGSize(width: itemWidth, height: thumbnailHeight + extraHeight) | ||
| return CGSize(width: itemWidth, height: totalHeight) |
Collaborator
There was a problem hiding this comment.
혹시 totalHeigh 이걸 계산 안하고 height에 let height = collectionView.bounds.height 이 height를 주는 방법은 실패하셨나요? 지금도 유동적으로 잘 보이긴하는데, 높이는 자동으로 계산되도록하고 height를 주는게 일반적인 것 같아서용
Collaborator
Author
There was a problem hiding this comment.
UICollectionViewFlowLayout.automaticSize 이걸 쓰면 자동계산이 되지만 아이패드 가로 세로 모드일때 뷰가 깨 질 수 있다고하네요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
수정사항
1.유저이미지 높이에 따라 셀 높이도 달라지도록 수정
2.탭바 겹치기는 문제 수정
할 일