[Feature] 유저는 홈 화면에서 리스트를 탭하면 해당 영상의 화면으로 이동 하여 재생된 영상을 볼 수 있다#60
Merged
[Feature] 유저는 홈 화면에서 리스트를 탭하면 해당 영상의 화면으로 이동 하여 재생된 영상을 볼 수 있다#60
Conversation
…dynamic video loading
|
You've used up your 5 PR reviews for this month under the Korbit Starter Plan. You'll get 5 more reviews on June 22nd, 2025 or you can upgrade to Pro for unlimited PR reviews and enhanced features in your Korbit Console. |
kdn0325
requested review from
TeddKo,
giseungNoh,
jihyeonjjang and
vinyl-nyl
and removed request for
vinyl-nyl
kdn0325
changed the title
vinyl-nyl
reviewed
Jun 13, 2025
| func setupPlayer(with urlString: String) { | ||
| guard let videoURL = URL(string: urlString) else { | ||
| print("Error: Invalid URL string.") | ||
| return |
vinyl-nyl
approved these changes
Jun 13, 2025
Collaborator
vinyl-nyl
left a comment
vinyl-nyl
left a comment
There was a problem hiding this comment.
URL 불러오는 부분 잘 바꿔주셨네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.