Skip to content

[PR] 코어데이터#7

Merged
TeddKo merged 4 commits intodevfrom
feature/core_data
Jun 9, 2025
Merged

[PR] 코어데이터#7
TeddKo merged 4 commits intodevfrom
feature/core_data

Conversation

@TeddKo
Copy link
Copy Markdown
Owner

@TeddKo TeddKo commented Jun 9, 2025

코어데이터 생성

확인사항

  • 데이터 타입 맞는지
  • 옵셔널이어야 하는게 맞는지
  • 관계가 잘 맺어졌는지

Description by Korbit AI

What change is being made?

Add .gitignore, define CoreData model entities (Tag, TimeStamp, Video), update Main.storyboard to include new scenes, and restructure view controllers and storyboards for Home, Like, and MyPage.

Why are these changes being made?

These changes introduce CoreData setup for structured data management and enhance project organization by updating the Xcode project with clear separation of views and controllers. The .gitignore ensures irrelevant files aren't tracked in version control, while the storyboard modifications align with new app navigation requirements.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

@TeddKo TeddKo self-assigned this Jun 9, 2025
Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this bear.

/  \.-"""-./  \
\    -   -    /
 |   o   o   |
 \  .-'''-.  /
  '-\__Y__/-'
     `---`
Files scanned

Due to the exceptionally large size of this PR, I've limited my review to the following files:

File Path Reviewed
PickaView/Views/LaunchScreen/LaunchScreenViewController.swift
PickaView/Views/MyPage/MyPageViewController.swift

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@giseungNoh
Copy link
Copy Markdown
Collaborator

확인했습니다!

Copy link
Copy Markdown
Collaborator

@kdn0325 kdn0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Collaborator

@vinyl-nyl vinyl-nyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@jihyeonjjang
Copy link
Copy Markdown
Collaborator

jihyeonjjang commented Jun 9, 2025

  • startTIme에 I 대문자로 오타 있습니다!
  • user_id lowerCamelCase로 작성 부탁드릴게요 ㅎㅎ
  • Tag.tag, TimeStamp.whole, Video.id는 옵셔널이 아니어도 될 것 같습니다.

@TeddKo TeddKo force-pushed the feature/core_data branch from 3e1d265 to 2bcca4d Compare June 9, 2025 05:33
@TeddKo TeddKo merged commit 25e4332 into dev Jun 9, 2025
@TeddKo TeddKo deleted the feature/core_data branch June 9, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants