Skip to content

[PR] LikeViewModel 추가 + down swipe gesture -> dismiss 추가#78

Merged
vinyl-nyl merged 1 commit intodevfrom
feature/LikeViewModel
Jun 15, 2025
Merged

[PR] LikeViewModel 추가 + down swipe gesture -> dismiss 추가#78
vinyl-nyl merged 1 commit intodevfrom
feature/LikeViewModel

Conversation

@vinyl-nyl
Copy link
Copy Markdown
Collaborator

  • LikeViewModel 추가
  • LikeViewController에 연결
  • Player 다운 스와이프 제스처 추가
  • 다운 스와이프 제스처로 dismiss 기능 추가

@korbit-ai
Copy link
Copy Markdown

korbit-ai Bot commented Jun 15, 2025

You've used up your 5 PR reviews for this month under the Korbit Starter Plan. You'll get 5 more reviews on June 22nd, 2025 or you can upgrade to Pro for unlimited PR reviews and enhanced features in your Korbit Console.

@vinyl-nyl vinyl-nyl changed the title LikeViewModel 추가 + down swipe gesture -> dismiss 추가 [PR] LikeViewModel 추가 + down swipe gesture -> dismiss 추가 Jun 15, 2025
@vinyl-nyl vinyl-nyl requested review from TeddKo and jihyeonjjang and removed request for TeddKo June 15, 2025 15:24
Copy link
Copy Markdown
Collaborator

@jihyeonjjang jihyeonjjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 👍

/// 변경된 셀 정보가 담긴 퍼블리셔. ViewController에서 이걸 구독하여 셀 업데이트 처리
let changesPublisher = PassthroughSubject<FRCChangeSet, Never>()

/// 좋아요된 비디오 목록. @Published로 UI 갱신 트리거
Copy link
Copy Markdown
Collaborator

@jihyeonjjang jihyeonjjang Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석도 한번만 수정해주세용

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정하겠습니다

@vinyl-nyl vinyl-nyl self-assigned this Jun 15, 2025
Copy link
Copy Markdown
Collaborator

@kdn0325 kdn0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

Copy link
Copy Markdown
Owner

@TeddKo TeddKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DocC 한번 확인해주세요 고생하셨습니다 👍

/// 변경된 셀 정보가 담긴 퍼블리셔. ViewController에서 이걸 구독하여 셀 업데이트 처리
let changesPublisher = PassthroughSubject<FRCChangeSet, Never>()

/// 좋아요된 비디오 목록. @Published로 UI 갱신 트리거
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@published로 UI 갱신 트리거 아니죠?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 수정하겠습니다

Copy link
Copy Markdown
Collaborator

@giseungNoh giseungNoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@vinyl-nyl vinyl-nyl merged commit b8ad6bd into dev Jun 15, 2025
@vinyl-nyl vinyl-nyl deleted the feature/LikeViewModel branch June 15, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants