Skip to content

Conversation

@ramsay
Copy link
Contributor

@ramsay ramsay commented May 29, 2018

The gson library doesn't handle nested HashMap objects without intervention. This changes the createRequestBody such that it will serialize the addons parameter separately than add to it all other simple key/value pairs from the params HashMap.

@codecov-io
Copy link

codecov-io commented May 29, 2018

Codecov Report

Merging #62 into master will increase coverage by 5.96%.
The diff coverage is 86.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
+ Coverage     61.93%   67.89%   +5.96%     
- Complexity       31       39       +8     
============================================
  Files             7        7              
  Lines           176      190      +14     
  Branches         17       19       +2     
============================================
+ Hits            109      129      +20     
+ Misses           61       53       -8     
- Partials          6        8       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/telesign/RestClient.java 89.83% <100%> (ø) 30 <4> (+1) ⬆️
src/main/java/com/telesign/PhoneIdClient.java 80% <83.33%> (+80%) 7 <4> (+7) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83493e7...f6da9df. Read the comment docs.

@ramsay ramsay merged commit 517da45 into master May 29, 2018
@release-at-telesign release-at-telesign deleted the feature/fix_application_json_support branch February 12, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants