fix: PR B — trust boundaries (round 4, bugs 5/6/8/9)#79
Merged
Conversation
Bug 5 (HIGH): WebSocket joinProperty unauthenticated - New WsAuthService (JWKS-backed, mirrors JwtStrategy) - Gateway verifies JWT on handleConnection, disconnects invalid sockets - joinProperty rejects unless user's JWT has the requested property_id (platform/admin roles bypass). AUTH_ENABLED=false preserves dev bypass. Bug 6 (HIGH): Guest PII cross-property leakage - All /guests/:id reads/updates/deletes + search now require propertyId - assertGuestAtProperty verifies ≥1 reservation at requesting property - Search uses inArray subquery scoped to reservations.propertyId - Create intentionally unscoped (walk-ins have no reservation yet) Bug 8 (HIGH): Stripe webhook signature verification broken - express.raw installed on /api/v1/webhooks/stripe before global JSON - Controller uses raw Buffer for stripe.webhooks.constructEvent Bug 9 (HIGH): JWT audience not validated - passport-jwt audience option enforced - azp claim also validated in validate() for Keycloak compatibility - KEYCLOAK_AUDIENCE documented in .env.example CLAUDE.md: guests exception corrected to require reservation-link check. 553/553 tests passing, build + typecheck clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of 4 PRs from round-4 codex review. Closes auth and PII leaks at integration seams.
CLAUDE.md
Guests exception corrected: the row is cross-property but API access MUST verify a reservation link at the requesting property.
Test plan
🤖 Generated with Claude Code