fix: PR C — operational (round 4, bugs 7/10/12)#80
Merged
Conversation
Bug 7 (HIGH): outbound webhook delivery not implemented - New webhook_deliveries table (id, subscriptionId, eventType, payload, status, attempts, nextRetryAt, lastStatusCode, lastError, etc.) - WebhookDeliveryService: async POST with HMAC-SHA256 signature, X-HAIP-Signature/Event-Id/Event-Type headers, 5s timeout - Exponential backoff 30s/2m/10m/1h/6h (5 attempts) - In-process setInterval scanner (30s) re-processes pending retries - GET /connect/subscriptions/:id/deliveries for observability - BullMQ deferred — Redis not wired up, pragmatic fallback per brief Bug 10 (HIGH): push-schema.ts missing tables - Added: agent_configs, agent_decisions, agent_training_snapshots, tax_profiles, tax_rules, guest_reviews, webhook_deliveries - Enums: agent_type, agent_mode, agent_decision_status, tax_rule_type, review_source, review_response_status, webhook_delivery_status - Long-term: replace push-schema.ts with real Drizzle migrations Bug 12 (MEDIUM): agent config mutations unaudited - updateConfig writes audit_logs row with per-field diff (isEnabled, mode, autopilotConfidenceThreshold, config), no-op changes skipped - approveDecision, rejectDecision also audited with actor from @currentuser - Reused existing auditLogs table; no new schema 562/562 tests passing (+9), build + typecheck clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third of 4 PRs from round-4 codex review. Operational correctness.
Notes
Test plan
🤖 Generated with Claude Code