fix(ci): release workflow must fail on test failures#73
Merged
Conversation
The previous step used `pnpm test 2>&1 || true`, swallowing test failures so a broken release could publish with a misleading test count. Split into two steps: 1. Run tests — fails the job on non-zero exit (relies on bash pipefail, which is the default in GitHub Actions). 2. Capture test counts — runs only when tests pass, reading the tee'd log. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
telivity-otaip
pushed a commit
that referenced
this pull request
Apr 18, 2026
Eleven PRs (#73–#83) merged since 0.6.2: - Codex review closeout (12 findings, all severities) - First npm publish of the @otaip/* scope - HTTP hardening (fetchWithRetry, https defaults) - EU 261 + US DOT IDB regulation modules in @otaip/core - Per-transaction GDS/NDC routing - ATPCO-rule-driven change/refund penalties (no invented defaults) - CLI agent registry auto-discovery - Bootstrap docs + single-source agent count - CI/publish workflow hardening (fail on test failures, verify packages live) Root + 15 workspace packages bumped 0.6.2 → 0.6.3. See CHANGELOG.md 0.6.3 entry for full detail and potentially-breaking notes. Verification: 3,092 tests pass, all 16 packages build, dry-run publish emits 15 tarballs at 0.6.3. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex review HIGH #1.
The previous `Run tests and capture count` step used `pnpm test 2>&1 || true`, swallowing test failures so a broken release could publish with a misleading "all green" count. Split into two steps:
Test plan
🤖 Generated with Claude Code