Skip to content

Feature - Upgrade gem syntax and Faraday#15

Merged
damdl96 merged 10 commits into
masterfrom
feature/upgrade-syntax-and-faraday
Jul 1, 2021
Merged

Feature - Upgrade gem syntax and Faraday#15
damdl96 merged 10 commits into
masterfrom
feature/upgrade-syntax-and-faraday

Conversation

@damdl96
Copy link
Copy Markdown
Contributor

@damdl96 damdl96 commented Jul 1, 2021

Context

Updates to faraday due to dependencies issues

Changes made

  • Upgrade faraday to use ~> 1.0
  • Remove active support dependency
  • Use of `JSON ruby library to generate JSON objects
  • Update syntax to Rails 6.1 standards
  • use of attr_accessor instead of cattr_accessor
  • Use of superclass variables.

Checklist

  • Tested locally
  • Ready for Peer Review

External Resources

@damdl96 damdl96 requested review from Chincoya and lutzcc1 July 1, 2021 15:54
@damdl96 damdl96 self-assigned this Jul 1, 2021
@damdl96 damdl96 changed the base branch from master to develop July 1, 2021 15:54
@damdl96 damdl96 changed the base branch from develop to master July 1, 2021 16:22
Copy link
Copy Markdown
Contributor

@Chincoya Chincoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damdl96 The changes look good. I did not think of that solution for replacing cattr_accessor the last time I was here. Noice. 👍🏾

Copy link
Copy Markdown

@lutzcc1 lutzcc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was quite a journey. Awesome job. Thanks, @damdl96! 👊

@lutzcc1
Copy link
Copy Markdown

lutzcc1 commented Jul 1, 2021

As an extra note. We should definitely get back to work on a new version of this gem. I think we can do improvements @damdl96

@damdl96
Copy link
Copy Markdown
Contributor Author

damdl96 commented Jul 1, 2021

There is definitely some elements to be addressed, let's take them into consideration for future releases.

@damdl96 damdl96 merged commit f6c57a7 into master Jul 1, 2021
@damdl96 damdl96 deleted the feature/upgrade-syntax-and-faraday branch July 1, 2021 18:19
@damdl96 damdl96 mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants