[DSL] Add support for a nullable annotation in SQL#333
Draft
[DSL] Add support for a nullable annotation in SQL#333
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #333 +/- ##
========================================
Coverage 99.01% 99.02%
========================================
Files 135 135
Lines 2857 2860 +3
Branches 43 46 +3
========================================
+ Hits 2829 2832 +3
Misses 28 28
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to add support in Go, which will involve treating a lot of stuff as pointers, and checking that the postgres bindings support that (how else can you set stuff to null/non-null dynamically?).
This reverts commit ec842ef on PR #332.