-
Notifications
You must be signed in to change notification settings - Fork 34
fix: larger pagination window for github releases #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1690b33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @osis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the reliability of fetching GitHub releases by expanding the pagination window for API requests. By increasing the number of items retrieved per page, the system is better equipped to locate specific release versions, especially in scenarios where projects have numerous releases or when searching for versions that might not appear on the initial default page. This adjustment provides more flexibility and robustness in release management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an issue with GitHub release pagination by increasing the number of items per page. The approach is valid, but the implementation of modifying the URL by string concatenation is brittle. I've added a suggestion to use the URL API for a more robust solution, which will prevent potential issues if the base URL already contains query parameters. I also noted that the page size is a magic number and would be better as a named constant.
f9e7d29 to
1690b33
Compare
Short description of work done
Given a certain newer releases, pinned version might fall out of the pagination window on the first page. While going through all the pages to get an older version isn't the best behaviour when testing wallets, opening up the window gives us a bit more breathing room as wallets continue to make major changes that take time to adapt to.
PR Checklist
Issues
Closes #506 #507