Skip to content

Conversation

@osis
Copy link
Collaborator

@osis osis commented Dec 10, 2025

Short description of work done

Given a certain newer releases, pinned version might fall out of the pagination window on the first page. While going through all the pages to get an older version isn't the best behaviour when testing wallets, opening up the window gives us a bit more breathing room as wallets continue to make major changes that take time to adapt to.

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally

Issues

Closes #506 #507

@osis osis requested a review from a team as a code owner December 10, 2025 18:53
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

🦋 Changeset detected

Latest commit: 1690b33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tenkeylabs/dappwright Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link

Summary of Changes

Hello @osis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of fetching GitHub releases by expanding the pagination window for API requests. By increasing the number of items retrieved per page, the system is better equipped to locate specific release versions, especially in scenarios where projects have numerous releases or when searching for versions that might not appear on the initial default page. This adjustment provides more flexibility and robustness in release management.

Highlights

  • Increased GitHub API Pagination: The per_page parameter for GitHub API requests has been increased to 100, allowing more release entries to be fetched in a single request.
  • Improved Release Discovery: This change addresses an issue where newer or older pinned versions of releases might fall outside the default pagination window, ensuring more reliable discovery of releases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue with GitHub release pagination by increasing the number of items per page. The approach is valid, but the implementation of modifying the URL by string concatenation is brittle. I've added a suggestion to use the URL API for a more robust solution, which will prevent potential issues if the base URL already contains query parameters. I also noted that the page size is a magic number and would be better as a named constant.

@osis osis force-pushed the larger-release-pagination-window branch from f9e7d29 to 1690b33 Compare December 10, 2025 18:59
@osis osis merged commit b625cce into main Dec 10, 2025
4 checks passed
@osis osis deleted the larger-release-pagination-window branch December 10, 2025 19:03
@github-actions github-actions bot mentioned this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update recommended version

2 participants