-
Notifications
You must be signed in to change notification settings - Fork 34
feat: metamask 13 support #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9442b54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @osis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request brings Dappwright up to date with MetaMask version 13 beta. It involves a comprehensive overhaul of the interaction logic for various MetaMask functionalities, from network and account management to token operations and initial setup. The changes are crucial for maintaining seamless automated testing and interaction capabilities with the latest MetaMask release. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project to support MetaMask v13 beta. The changes are extensive, touching many files to adapt to the new UI flows and selectors. A number of helper functions have been introduced in util.ts to improve code reuse and maintainability, which is a great improvement. I've identified a few areas for improvement, including a potential bug in balance parsing and some opportunities to enhance code maintainability. Overall, this is a solid and necessary update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically waited for 13.12.x where there is more flexibility when setting up the wallet to turn off backup & sync. Without this option disabled, there would have to be 3-5min waits for the list of accounts to sync since the test wallet has > 200 accounts.
Waiting for this flexibility also meant that we got introduced to the new side panel UI that MetaMask has incorporated. Playwright doesn't really consider the side panel to be part of it's official supported mechanisms but you can dig the page out of the browser context.
Doing requires an environment flag (PW_CHROMIUM_ATTACH_TO_OTHER = '1') to be set before the context is created. Since dAppwright creates its own context, this is easy for us to do at runtime without introducing a breaking change for burdening users with this context.
Beyond this, MetaMask is looking better than ever. Always like seeing all the easier ways folks can onboard into the ecosystem.
Short description of work done
Support for Metamask 13
PR Checklist