[Feature] Firestorm supports node's health check #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
jerqi
changed the title
colinmjj
reviewed
Nov 16, 2021
server/src/main/java/com/tencent/rss/server/ShuffleServerConf.java
Outdated
Show resolved
Hide resolved
colinmjj
reviewed
Nov 17, 2021
server/src/main/java/com/tencent/rss/server/ShuffleServerConf.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@colinmjj comments are addressed. |
duanmeng
reviewed
Nov 18, 2021
duanmeng
reviewed
Nov 18, 2021
common/src/main/java/com/tencent/rss/common/config/ConfigUtils.java
Outdated
Show resolved
Hide resolved
duanmeng
reviewed
Nov 18, 2021
duanmeng
reviewed
Nov 18, 2021
duanmeng
reviewed
Nov 18, 2021
duanmeng
reviewed
Nov 18, 2021
duanmeng
reviewed
Nov 18, 2021
server/src/main/java/com/tencent/rss/server/ShuffleServerConf.java
Outdated
Show resolved
Hide resolved
duanmeng
reviewed
Nov 18, 2021
server/src/main/java/com/tencent/rss/server/StorageChecker.java
Outdated
Show resolved
Hide resolved
duanmeng
reviewed
Nov 18, 2021
Collaborator
|
Please write more details about this pr's goal maybe some background and design in the what section. |
duanmeng
reviewed
Nov 18, 2021
duanmeng
reviewed
Nov 18, 2021
server/src/test/java/com/tencent/rss/server/StorageCheckerTest.java
Outdated
Show resolved
Hide resolved
duanmeng
reviewed
Nov 18, 2021
integration-test/common/src/test/java/com/tencent/rss/test/HealthCheckCoordinatorGrpcTest.java
Show resolved
Hide resolved
duanmeng
reviewed
Nov 18, 2021
server/src/test/java/com/tencent/rss/server/HealthCheckTest.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
All comments are addressed. |
Collaborator
|
LGTM |
colinmjj
reviewed
Nov 22, 2021
Collaborator
|
LGTM |
colinmjj
previously approved these changes
Nov 23, 2021
colinmjj
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Firestorm supports node's health check. There are some full disk nodes in our cluster, they influence the shuffle service. We should exclude them.Currently we only check disk usage, and exclude the unhealthy nodes.
Why are the changes needed?
Because we should have the mechanism to find the servers that can't serve, and screen them
Does this PR introduce any user-facing change?
No
How was this patch tested?
newly added UTs