[Feature] corrupted LocalStorage can be excluded #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
requested review from
colinmjj and
duanmeng
and removed request for
colinmjj
colinmjj
reviewed
Feb 25, 2022
server/src/main/java/com/tencent/rss/server/storage/SingleStorageManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/tencent/rss/server/storage/LocalStorageManager.java
Outdated
Show resolved
Hide resolved
frankliee
reviewed
Feb 25, 2022
duanmeng
reviewed
Feb 25, 2022
server/src/main/java/com/tencent/rss/server/LocalStorageChecker.java
Outdated
Show resolved
Hide resolved
frankliee
reviewed
Feb 25, 2022
Collaborator
|
LGTM, pending on CI |
Collaborator
Author
CI passed. |
colinmjj
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We check disk periodically, when a disk can't be read or write, we think this disk is corrupted, and shuffle server won't use this disk again.
Why are the changes needed?
Sometimes the disk of server will be corrupted, we hope to reduce the influence.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New UT