build: make cc_flare_library front-end-agnostic; upgrade vendored blade#211
Merged
Conversation
Rewrite the two Python-only constructs in the cc_flare_library extension so it parses under a Starlark front-end as well as Blade's (restricted) Python DSL, with identical behaviour under Blade: - `assert len(srcs) == 1, msg` -> `if len(srcs) != 1: fail(msg)` - `deps is None` -> `deps == None` - implicit adjacent-string concatenation -> explicit `+` `isinstance` is kept (both front-ends provide it). This lets flare build under a Go reimplementation of Blade (blade-go) without changing the current build. Also upgrade the vendored blade (thirdparty/blade/blade.zip + GITVERSION) to blade-build master, which adds the `fail()` builtin the change above uses. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the two Python-only constructs in the
cc_flare_libraryextension so it parses under a Starlark front-end as well as Blade's restricted Python DSL — identical behaviour under Blade:assert len(srcs) == 1, msg→if len(srcs) != 1: fail(msg)deps is None→deps == None+isinstanceis kept (both front-ends provide it). This lets flare build under a Go reimplementation of Blade (blade-go) without changing the current build.Also upgrades the vendored blade (
thirdparty/blade/blade.zip+GITVERSION) to blade-build master, which adds thefail()builtin the change above uses.🤖 Generated with Claude Code