fix: softmax x86 miss tail data feat: use rcp to replace 1/x#6368
Merged
nihui merged 7 commits intoTencent:masterfrom Oct 23, 2025
Merged
fix: softmax x86 miss tail data feat: use rcp to replace 1/x#6368nihui merged 7 commits intoTencent:masterfrom
nihui merged 7 commits intoTencent:masterfrom
Conversation
feat: use rcp to replace 1/x
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6368 +/- ##
==========================================
- Coverage 95.89% 95.89% -0.01%
==========================================
Files 840 840
Lines 265942 265941 -1
==========================================
- Hits 255022 255021 -1
Misses 10920 10920 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the x86 softmax implementation where tail data was incorrectly processed, and improves performance by replacing division operations with optimized reciprocal calculations using Newton-Raphson refinement.
Key changes:
- Fixed calculation of
nn_sizeto properly handle tail elements using ceiling division:(size + sizen - 1) / sizen - Introduced optimized reciprocal functions (
_mm_rcp_nr_ps,_mm256_rcp_nr_ps,_mm512_rcp_nr_ps) that use Newton-Raphson refinement for better accuracy than rawrcpapproximations - Replaced all
_mm*_div_psdivision operations with the new reciprocal functions throughout the softmax implementations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # src/layer/x86/softmax_x86.cpp
|
The binary size change of libncnn.so (bytes)
|
nihui
approved these changes
Oct 23, 2025
Member
|
Thanks for your contribution ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: softmax x86 miss tail
feat: use rcp to replace 1/x