fix modelwriter padding crash on empty per_channel_pad_data#6533
Merged
Conversation
Member
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in the ModelWriter when saving models with Padding layers that have empty per_channel_pad_data. The fix adds a size check before attempting to write the per-channel padding data to the binary file.
Changes:
- Added conditional check for
per_channel_pad_data_size > 0before writing per-channel padding data in the Padding layer serialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nihui
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.