[bugfix] pnnx: emit Erf layer for expression erf#6677
Merged
Conversation
Summary: Expand fused `erf` expressions into the dedicated `Erf` layer instead of routing them through `UnaryOp`, and add torchscript / ONNX coverage to prevent regressions. This avoids the unsupported `UnaryOp erf` path while keeping the rest of the expression expansion unchanged.
crafcat7
force-pushed
the
erf_pass_ncnn_bugfix
branch
from
9e486da to
921df24
Compare
Member
|
Thanks for your contribution ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand fused
erfexpressions into the dedicatedErflayer instead of routingthem through
UnaryOp, and add torchscript / ONNX coverage to prevent regressions.This avoids the unsupported
UnaryOp erfpath while keeping the rest of theexpression expansion unchanged.