armv8.4 bf16 convolution im2col-gemm optimization#6715
Conversation
|
@codex review |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6715 +/- ##
==========================================
- Coverage 93.86% 93.80% -0.07%
==========================================
Files 932 931 -1
Lines 307558 309894 +2336
==========================================
+ Hits 288694 290697 +2003
- Misses 18864 19197 +333 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
This PR refactors ARM im2col+GEMM convolution support to better integrate armv8.4 BF16 runtime-optimized code paths while consolidating shared packing/im2col helpers into the FP16 implementation header.
Changes:
- Moved/renamed the FP16 pack-A and im2col input-tile helpers into
convolution_im2col_gemm_fp16s.hand updated call sites to use the new*_fp16names. - Deleted the now-redundant
convolution_im2col_gemm_bf16s_fp16s.hheader and removed its includes. - Added
convolution_arm_bf16.cppto provide BF16 arch-opt wrapper symbols used by BF16 im2col+GEMM runtime dispatch.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/layer/arm/convolution_im2col_gemm_fp16s.h | Adds FP16 pack/im2col tile helpers and updates internal call sites to the new helper names. |
| src/layer/arm/convolution_im2col_gemm_bf16s_fp16s.h | Removes the redundant header after consolidation. |
| src/layer/arm/convolution_arm.cpp | Drops the removed header include. |
| src/layer/arm/convolution_arm_asimdhp.cpp | Drops the removed header include (FP16 path now self-contained via convolution_im2col_gemm_fp16s.h). |
| src/layer/arm/convolution_arm_bf16.cpp | Adds armv8.4 BF16 arch-opt wrappers to satisfy BF16 runtime-dispatch symbols. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
No description provided.