Skip to content

fix simplemath build, trigger ci on benchmark changes#6722

Merged
nihui merged 7 commits into
Tencent:masterfrom
nihui:fix-simplemath-build
May 14, 2026
Merged

fix simplemath build, trigger ci on benchmark changes#6722
nihui merged 7 commits into
Tencent:masterfrom
nihui:fix-simplemath-build

Conversation

@nihui
Copy link
Copy Markdown
Member

@nihui nihui commented May 14, 2026

No description provided.

@tencent-adm
Copy link
Copy Markdown
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added the core label May 14, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.97%. Comparing base (421de78) to head (b962377).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6722      +/-   ##
==========================================
+ Coverage   93.90%   93.97%   +0.06%     
==========================================
  Files         933      933              
  Lines      310041   310139      +98     
==========================================
+ Hits       291140   291440     +300     
+ Misses      18901    18699     -202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nihui nihui requested a review from Copilot May 14, 2026 03:04
@nihui
Copy link
Copy Markdown
Member Author

nihui commented May 14, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix build issues around the simplemath implementation (notably INFINITY) and to ensure CI workflows run when benchmark sources change.

Changes:

  • Define INFINITY in simplemath.h (guarded) and remove the local INFINITY macro from simplemath.cpp.
  • Adjust the LLM benchmark source includes.
  • Update multiple GitHub Actions workflows to trigger on benchmark/** changes (excluding benchmark/README.md), and tweak the linux-aarch64 simplestl+simplemath CMake invocation.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/simplemath.h Adds a guarded INFINITY macro for simplemath builds.
src/simplemath.cpp Removes the local INFINITY macro definition.
benchmark/benchncnn_llm.cpp Removes <math.h> include (but file uses INFINITY).
.github/workflows/windows.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/macos.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/linux-x64-sde.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/linux-x64-gpu-gcc.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/linux-x64-gpu-clang.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/linux-x64-cpu-gcc.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/linux-x64-cpu-gcc-musl.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/linux-x64-cpu-clang.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/linux-riscv64.yml Trigger CI on benchmark path changes (excluding README).
.github/workflows/linux-aarch64.yml Trigger CI on benchmark path changes and removes explicit benchmark-disable for simplestl+simplemath job.
Comments suppressed due to low confidence (1)

benchmark/benchncnn_llm.cpp:8

  • This file uses INFINITY (e.g., for -INFINITY in attention_mask), but <math.h> was removed and none of the included ncnn headers define INFINITY. This will fail to compile on toolchains that don’t predefine INFINITY. Re-add <math.h>/<cmath> or switch to a local definition (e.g., std::numeric_limits<float>::infinity() if available).
#include <float.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/simplemath.h
Comment thread src/simplemath.cpp Outdated
nihui and others added 2 commits May 14, 2026 11:12
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@nihui nihui requested a review from Copilot May 14, 2026 03:13
@nihui
Copy link
Copy Markdown
Member Author

nihui commented May 14, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/linux-aarch64.yml
@nihui nihui merged commit 244572a into Tencent:master May 14, 2026
111 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants