Skip to content

Fix build warnings emitted by GCC 10 on Aarch64#1776

Open
philn wants to merge 1 commit intoTencent:masterfrom
philn:gcc-10-aarch64
Open

Fix build warnings emitted by GCC 10 on Aarch64#1776
philn wants to merge 1 commit intoTencent:masterfrom
philn:gcc-10-aarch64

Conversation

@philn
Copy link

@philn philn commented Sep 7, 2020

No description provided.

@miloyip
Copy link
Collaborator

miloyip commented Sep 7, 2020

This code is needed for sizeof(Ch) > 1. Otherwise the array lookup will be out of bound.
May need to add some pragma to disable warning.

@philn
Copy link
Author

philn commented Sep 7, 2020

The value of unsigned vars can't be higher than 255 though. Instead of a pragma this might need some rework.

@miloyip
Copy link
Collaborator

miloyip commented Sep 7, 2020

Ch can be std::uint16_t or other types.

@ccawley2011
Copy link

PR #1895 adds the necessary pragmas to disable these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants