Skip to content

优化demo#330

Merged
progrape merged 3 commits intoTencent:masterfrom
karlew:master
Apr 19, 2016
Merged

优化demo#330
progrape merged 3 commits intoTencent:masterfrom
karlew:master

Conversation

@karlew
Copy link
Contributor

@karlew karlew commented Apr 19, 2016

为tab中navbar和tabbar里标签添加点击事件交互,方便查看实际效果

为tab中navbar和tabbar里标签添加点击事件交互,方便查看实际效果
@progrape
Copy link
Collaborator

@karlew 这个优化挺需要的,不过建议移除 class 的时候,使用 siblings 方式,选择当前元素的兄弟元素来移除,这样范围更精确,谢谢。

$(this).addClass('weui_bar_item_on').siblings('.weui_bar_item_on').removeClass('weui_bar_item_on');

karlew added 2 commits April 19, 2016 14:53
为tab中navbar和tabbar里标签添加点击事件交互,方便查看实际效果
为tab中navbar和tabbar里标签添加点击事件交互,方便查看实际效果
@karlew
Copy link
Contributor Author

karlew commented Apr 19, 2016

感谢 @progrape 提醒,确实应该像您说的那样写,避免影响其他菜单的元素,现已修正

@progrape progrape merged commit 3a6eaf7 into Tencent:master Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants