Skip to content

docs(cubecow): remove License section from README#369

Merged
fslongjin merged 1 commit into
TencentCloud:masterfrom
lisongqian:fix-doc
May 27, 2026
Merged

docs(cubecow): remove License section from README#369
fslongjin merged 1 commit into
TencentCloud:masterfrom
lisongqian:fix-doc

Conversation

@lisongqian
Copy link
Copy Markdown
Collaborator

The "## License" section (MIT) has been removed from cubecow/README.md
since licensing is tracked elsewhere in the repository and the section
duplicated information that does not belong in the per-crate README.

Signed-off-by: Songqian Li sionli@tencent.com

The "## License" section (MIT) has been removed from cubecow/README.md
since licensing is tracked elsewhere in the repository and the section
duplicated information that does not belong in the per-crate README.

Signed-off-by: Songqian Li <sionli@tencent.com>
@cubesandboxbot
Copy link
Copy Markdown

cubesandboxbot Bot commented May 27, 2026

Claude finished @lisongqian's task in 33s —— View job


Review: docs(cubecow): remove License section from README

Checklist

  • Analyze the diff and read changed files
  • Verify rationale and consistency with repo conventions
  • Provide review feedback

Summary

This PR removes the ## License section from cubecow/README.md, which previously stated the crate was licensed under MIT.

Observations

The change is correct and should be merged. A few points worth noting:

  1. The License section was factually wrong. The root LICENSE file declares the project as Apache-2.0, not MIT. Removing the section eliminates this misinformation.

  2. Other crate READMEs handle this differentlyagent/README.md and CubeShim/README.md include a License section that correctly says "Apache-2.0 — see LICENSE for details." Both approaches (omit entirely vs. link to root LICENSE) are defensible. The PR author's rationale that "licensing is tracked elsewhere" is valid, especially since the incorrect MIT text made removal the better call here.

  3. Whitespace cleanup: The closing ``` of the preceding code block is properly added back, so no formatting breakage.

Verdict

Approved — clean, single-purpose change with correct reasoning.

@fslongjin fslongjin merged commit 78e8287 into TencentCloud:master May 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants