Skip to content

Removed Subvolume panel from Volume dashboard#571

Merged
cybernth merged 1 commit intoTendrl:masterfrom
GowthamShanmugam:1614263
Sep 12, 2018
Merged

Removed Subvolume panel from Volume dashboard#571
cybernth merged 1 commit intoTendrl:masterfrom
GowthamShanmugam:1614263

Conversation

@GowthamShanmugam
Copy link
Collaborator

bugzilla: 1614263
tendrl-bug-id: #570

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

@GowthamShanmugam GowthamShanmugam requested a review from a team as a code owner September 11, 2018 13:27
@GowthamShanmugam
Copy link
Collaborator Author

removed_sub_vol

@cloudbehl i removed this from code directly not removed from grafana and copied json, please review this PR and check my changes are correct

@GowthamShanmugam
Copy link
Collaborator Author

I tested dashboard is looks fine

@GowthamShanmugam
Copy link
Collaborator Author

@mbukatov @julienlim

Copy link
Member

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we increase the width of Geo-Replication sessions panel a bit? Otherwise looks fine to me.

@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files          40       40           
  Lines        2300     2300           
  Branches      345      345           
=======================================
  Hits         1037     1037           
  Misses       1210     1210           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46ae97...87a689b. Read the comment docs.

@GowthamShanmugam
Copy link
Collaborator Author

remove_subvol

Modified alignment as per @shtripat comment

@shtripat
Copy link
Member

Looks good to me now

@cloudbehl
Copy link
Member

@GowthamShanmugam @shtripat I will recommend we should not reduce the alignment of any panel. We can increase it but reduction may lead to some regressions.

I will recommend we change the rebalance status back to the original width. If we want to change the width of geo-rep then we can reduce the width of the rebalance panel.

bugzilla: 1614263
tendrl-bug-id: Tendrl#570

Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
@GowthamShanmugam
Copy link
Collaborator Author

@cloudbehl i reverted back that new change

@cybernth cybernth merged commit 7aff35d into Tendrl:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants