Cleanup and modernization#13
Merged
Tennessene merged 3 commits intomainfrom Dec 29, 2023
Merged
Conversation
This was most likely for debugging, but I don't see a need for it. It doesn't seem good to throw deliberate exceptions anyway
A lot was done to update and optimize the code
Added the -noconsole option to mute console output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to redo #12 because of conflicts
We should merge this, but the SHA codes are different because I wanted to change the date of a couple of commits to be more accurate. Also, some things need to be fixed. I had to change things temporarily just to get jDOSBox to run
If you let this method have memory.pages like it used to, it will throw an error saying pages is null. Normally it's 4096, so I added it just to get it working. The original problem must be fixed though. It was caused by the Java optimization
jDOSBox/jdosbox/src/main/java/jdos/hardware/Memory.java
Line 461 in 38b7778
Also, the config parsers are now messed up for some reason. I tried fixing them and I think it's working, but it wasn't an issue before
jDOSBox/jdosbox/src/main/java/jdos/gui/MainBase.java
Line 507 in 38b7778