fix: upsert dataset_feature_name_mapping if specified with dataset#139
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures custom data_features_name_mapping overrides are available when datasets are loaded via PyTorch DataLoader workers (which run in separate processes under spawn), so feature standardization works consistently across parent and worker processes.
Changes:
- Register
DatasetConfig.data_features_name_mappinginto the globalDATA_FEATURES_NAME_MAPPINGduring config initialization. - Add a
worker_init_fntoWeightedDatasetMixture.get_dataloader()to apply mapping overrides inside each worker process.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/opentau/datasets/dataset_mixture.py |
Adds a worker init hook to upsert mapping overrides in DataLoader worker processes. |
src/opentau/configs/default.py |
Upserts config-provided feature mappings into the global mapping during DatasetConfig.__post_init__. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
WilliamYue37
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fix #138
How it was tested
Removed the following section from
standard_data_format_mapping.pyand added the following to
pi05_training_config.jsonand trained with
How to checkout & try? (for the reviewer)
Remove the following section from
standard_data_format_mapping.pyand add the following to
pi05_training_config.jsonand train with
Checklist
Note: Before submitting this PR, please read the contributor guideline.