Skip to content

Support convert checkpoint from any directory#148

Merged
shuheng-liu merged 5 commits into
mainfrom
fix/convert-checkpoint-cwd
Mar 26, 2026
Merged

Support convert checkpoint from any directory#148
shuheng-liu merged 5 commits into
mainfrom
fix/convert-checkpoint-cwd

Conversation

@shuheng-liu
Copy link
Copy Markdown
Member

What this does

Convert checkpoint from any directory

How it was tested

Ran convert_checkpoint.sh from another directory.

How to checkout & try? (for the reviewer)

Activate virtual env and run convert_checkpoint.sh from any directory.

Checklist

  • I have added Google-style docstrings to important functions and ensured function parameters are typed.
  • My PR includes policy-related changes.
    • If the above is checked: I have run the GPU pytests (pytest -m "gpu") and regression tests.

Copilot AI review requested due to automatic review settings March 23, 2026 19:37
@shuheng-liu shuheng-liu changed the title Fix/convert checkpoint cwd Support convert checkpoint from any directory. Mar 23, 2026
@shuheng-liu shuheng-liu changed the title Support convert checkpoint from any directory. Support convert checkpoint from any directory Mar 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the checkpoint conversion shell script so it can run the underlying conversion utilities via module execution (python -m ...), avoiding assumptions about the current working directory.

Changes:

  • Add a guard to prevent overwriting an existing model.safetensors in the checkpoint directory.
  • Switch conversion invocations from relative file paths to python -m opentau.scripts.* module execution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/opentau/scripts/convert_checkpoint.sh Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
WilliamYue37
WilliamYue37 previously approved these changes Mar 23, 2026
@shuheng-liu shuheng-liu merged commit ed557ee into main Mar 26, 2026
5 checks passed
@shuheng-liu shuheng-liu deleted the fix/convert-checkpoint-cwd branch March 26, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants