Support empty mixture weights (default to lengths)#149
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for omitting dataset mixture weights by inferring defaults from dataset lengths, allowing configs to leave weights unset while still producing a valid WeightedDatasetMixture.
Changes:
- Make
DatasetMixtureConfig.weightsoptional (Nonemeans infer at runtime). - Infer train/val mixture weights from
float(len(dataset))when weights areNone. - Document the new optional-weights behavior and add a config-level test for
weights=None.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/configs/test_default.py | Adds a test ensuring DatasetMixtureConfig accepts weights=None. |
| src/opentau/datasets/factory.py | Infers mixture weights from dataset lengths when weights is None (train and val). |
| src/opentau/configs/default.py | Updates config typing/docs and relaxes validation to allow weights=None. |
| docs/source/tutorials/datasets.rst | Documents that weights can be omitted/null and will be inferred from lengths. |
| docs/source/concepts.rst | Notes default-to-lengths behavior when weights are omitted/null. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WilliamYue37
previously approved these changes
Mar 23, 2026
WilliamYue37
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Support empty mixture weights (default to lengths)
How it was tested
Ran tests without specifying mixture weights.
How to checkout & try? (for the reviewer)
Run tests without specifying mixture weights.
Checklist