ci: remove concurrency group from cpu_test workflow#248
Conversation
| group: cpu-test-${{ github.head_ref || github.ref_name }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: |
There was a problem hiding this comment.
Re-introduces the self-race that PR #232 explicitly fixed. cpu_test.yml triggers on both pull_request and push (lines 19-20) without branch filters, so every push to a PR branch fires two concurrent runs at the same SHA. Per #232, those duplicate runs race on shared external resources (HF Hub auth + dataset downloads) and the losing one consistently fails — burning ~8 min of CPU twice and producing the very red checks this PR is trying to avoid.
If the original concern is that cancelled runs show as failed status checks, milder fixes preserve dedup:
- Switch
cancel-in-progress: true→cancel-in-progress: false(queue rather than cancel; no run is ever cancelled, so no "failed" status from cancellation). - Or restrict
push:tobranches: [main]so PR pushes only firepull_requestonce, then drop the concurrency block.
Worth verifying that cancelled runs were actually showing as failed (not cancelled) before reverting #232 — branch protection treats those distinctly by default.
|
[claude-review] summary for commit 2231d1d
|
What this does
Removes the
concurrencyblock from.github/workflows/cpu_test.yml. Withcancel-in-progress: true, every superseded run on a PR was reported as a failed status check, making PRs look red even when the underlying tests would have passed on a fresh run.How it was tested
No code paths changed — workflow-config-only edit. Verified the YAML still parses by running pre-commit (
check yaml,zizmor, etc. all pass). CI on this PR will exercise the new behavior end-to-end.How to checkout & try? (for the reviewer)
Checklist
Note: Before submitting this PR, please read the contributor guideline.
Generated by Claude Code