test: remove tests requiring private TensorAuto/*-untrained repos (#272)#279
Conversation
The nightly GPU job 404s when fetching TensorAuto/pi06-untrained, TensorAuto/pi07-high-untrained, and TensorAuto/pi07-low-untrained, since the CI HF_TOKEN can't read these private repos. Drop the affected tests and their fixtures.
There was a problem hiding this comment.
Reviewed deletions only — verified no remaining references to the removed fixtures/helpers (pi06_untrained_policy, pi07_*_untrained_policy, _diff_state_dicts_against_reference, _assert_no_missing_or_unexpected, gemma3_4b_pt_aligned_state_dict) and no orphaned imports in test_pi06.py. CPU subset of test_pi06.py is intact. One minor stale doc reference noted inline.
|
[claude-review] summary for commit 6db70fd No blocking issues found. The two nits from the prior review pass were addressed in 6db70fd as docstring/comment-only edits — verified the new comment in |
|
@claude fix the nits |
- addresses @claude[bot] (test_vision_utils.py:54): replaced the comment's stale reference to the removed test_pi06_untrained_siglip_matches_gemma3_4b_pt symbol with a pointer to the bilinear_resample_pos_embed docstring, which already explains the byte-equality bootstrap motivation. - addresses @claude[bot] (test_default.py:209,246): rephrased two docstrings on TestPretrainedConfigCodec to drop the now-stale TensorAuto/pi07-{high,low}-untrained repo names while preserving the historical bug context (codec round-trip required for π0.7 planner checkpoint bootstrap). tests: skipped — docstring/comment-only edits in two test files; no imports, function bodies, control flow, or runtime-read configs touched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
[claude-fix] both nits addressed in 6db70fd.
Tests skipped: docstring/comment-only edits in two test files, no imports / function bodies / control flow / runtime-read configs touched. |
What this does
Fixes #272 (🐛 Bug). The nightly Run Pytest on GPU job has been failing with 8 fixture-setup
ERRORs because the CIHF_TOKENcan't see three private repos underTensorAuto/*:TensorAuto/pi06-untrainedTensorAuto/pi07-high-untrainedTensorAuto/pi07-low-untrainedThis PR removes the affected tests and their now-unused fixtures, taking option (3) from the issue's suggested fixes (skip-on-unreachable, but as a removal rather than a runtime probe — the tests can be added back behind a token-aware fixture if/when the repos are made public or the token is rotated).
Removed:
tests/policies/test_pi07_untrained.py(entire file — every test in it loaded one of the private pi07 repos)TensorAuto/pi06-untrainedcheckpoint" section at the bottom oftests/policies/test_pi06.py(thepi06_untrained_policy/gemma3_4b_pt_aligned_state_dictfixtures, the_diff_state_dicts_against_referencehelper, and the three tests that consumed them — including the already-@pytest.mark.skip'd VLM-match test, since its fixtures were the only remaining users of the helper).The CPU-only tests in
test_pi06.py(block-causal mask semantics, RoPE θ selection, SDPA equivalence, gradient-checkpointing equivalence, etc.) are untouched.How it was tested
A grep for
TensorAuto/pi0[67]*-untrainedshows only one remaining hit, in a docstring attests/configs/test_default.py:246— that's just historical context, not a code path.How to checkout & try? (for the reviewer)
On the GPU box, the previously-failing collection should now be empty:
Checklist
Note: Before submitting this PR, please read the contributor guideline.