Skip to content

Conversation

@samuelsonric
Copy link
Contributor

I have added two tropical number types.

  • TropicalMaxMin: this is sometimes called the bottleneck semiring
  • TropicalBitwise: this generalizes TropicalAndOr

I also flipped the ordering of TropicalMinPlus.

Copy link
Member

@GiggleLiu GiggleLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also change the README to reflect the added semiring types.

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 89.65517% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.69%. Comparing base (3db3389) to head (75324a7).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/tropical_bitwise.jl 84.61% 6 Missing ⚠️
src/tropical_maxmin.jl 93.10% 2 Missing ⚠️
src/TropicalNumbers.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   86.16%   86.69%   +0.53%     
==========================================
  Files           6        8       +2     
  Lines         159      233      +74     
==========================================
+ Hits          137      202      +65     
- Misses         22       31       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GiggleLiu
Copy link
Member

GiggleLiu commented Nov 2, 2025

I found a long debate about the meaning of isless, <, cmp here: https://discourse.julialang.org/t/meaning-of-isless-cmp-isequal-total-order-partial-order-unordered/8176/20

I was just wondering why I added so many functions for comparison. It seems there is no easy way to define comparison with single API.

@GiggleLiu GiggleLiu merged commit 59a22d6 into TensorBFS:master Nov 2, 2025
4 checks passed
@GiggleLiu
Copy link
Member

To speed up the pipeline, I made some minor fixes to documentation and tests and merged the PR.

@samuelsonric
Copy link
Contributor Author

Hi @GiggleLiu, thank you for updating the documentation for me. It hadn't occurred to me to do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants