-
Notifications
You must be signed in to change notification settings - Fork 3
Add types TropicalMaxMin and TropicalBitwise.
#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please also change the README to reflect the added semiring types.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 86.16% 86.69% +0.53%
==========================================
Files 6 8 +2
Lines 159 233 +74
==========================================
+ Hits 137 202 +65
- Misses 22 31 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I found a long debate about the meaning of I was just wondering why I added so many functions for comparison. It seems there is no easy way to define comparison with single API. |
|
To speed up the pipeline, I made some minor fixes to documentation and tests and merged the PR. |
|
Hi @GiggleLiu, thank you for updating the documentation for me. It hadn't occurred to me to do that! |
I have added two tropical number types.
TropicalMaxMin: this is sometimes called the bottleneck semiringTropicalBitwise: this generalizesTropicalAndOrI also flipped the ordering of
TropicalMinPlus.