Skip to content

feat(): upgrade to angular@4.0.0. (closes #393)#429

Merged
emoralesb05 merged 25 commits into
developfrom
feature/upgrade-4
Mar 26, 2017
Merged

feat(): upgrade to angular@4.0.0. (closes #393)#429
emoralesb05 merged 25 commits into
developfrom
feature/upgrade-4

Conversation

@emoralesb05

@emoralesb05 emoralesb05 commented Mar 16, 2017

Copy link
Copy Markdown
Contributor

Description

#393
Starting the PR (will set its description later)

What's included?

  • chore(): upgrade to angular@4.0.0 (and dependencies)
  • feat(): replace template with ng-template
  • feat(): replace OpaqueToken with InjectionToken
  • feat(): import BrowserAnimationsModule where needed
  • chore(flex-layout): update to rc.1 for ng@4.0.0 support
  • feat(): remove Renderer infavor of Renderer2
  • feat(toggle): support for ng4
  • feat(fade): support for ng4

Test Steps

  • do this
  • then this
  • finally this

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

@emoralesb05 emoralesb05 added this to the Beta 3 milestone Mar 16, 2017
@emoralesb05 emoralesb05 changed the title feat(): upgrade to angular@4.0.0 feat(): upgrade to angular@4.0.0. (closes #393) Mar 16, 2017
@joshwiens

joshwiens commented Mar 22, 2017

Copy link
Copy Markdown
Contributor

On the off chance you missed this as opposed to just haven't gotten to it yet..

src/platform/core/common/animations fade && toggle are still using renderer.setElementStyle

Update: evidently we aren't getting programatic access to animations in 4.0.0 and have to wait until 4.1.0-beta and then use AnimationBuilder

@emoralesb05

emoralesb05 commented Mar 22, 2017

Copy link
Copy Markdown
Contributor Author

Yep! 😄 , i was waiting on this to see if we can still use Renderer for now or access directly @angular/animations/browser pre 4.1.0-beta as stated in angular/angular#15294 (comment). If Renderer will still be there until 4.1.0, then we can just keep using it for now.

@mmoravcik

Copy link
Copy Markdown

Any idea when is this going to be released? Great framework BTW

@joshwiens

Copy link
Copy Markdown
Contributor

@mmoravcik - It's available in the nightly

@mmoravcik

Copy link
Copy Markdown

@d3viant0ne thanks but still getting the following when running ng build prod with CLI

ERROR in _gendir/node_modules/@covalent/core/data-table/data-table.component.ngfactory.ts     (1,1): Property '_selectable' is private and only accessible within class 'TdDataTableComponent'.

/node_modules/@covalent/core/data-table/data-table.component.html (14,5): Property '_data' is private and only accessible within class 'TdDataTableComponent'.

$$_gendir/node_modules/@covalent/core/data-table/data-table.component.ngfactory.ts (1,1): Property '_selectable' is private and only accessible within class 'TdDataTableComponent'.

@joshwiens

Copy link
Copy Markdown
Contributor

Already reported in #471 which has an open pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants