feat(layout): introducing layout toggle directives#657
Merged
Conversation
to allow more flexibility using `td-layout`, `td-layout-nav-list` and `td-layout-manage-list` we removed the toggle button from the component and created a few toggle directives so developers can pick and choose how and when to add them
before we needed to check if `td-layout-nav` was a child component of any `td-layout` wrapper. now we will remove that dependency all together and the menu button in favor of a `[td-menu-button]` placeholder so users can add their own button and add `[tdLayoutToggle]` or their own sidenav.
|
Hi, is it possible to have something like "hideWhenClosed"? or a way to get the current status (true = opened, false = close)? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to allow more flexibility using
td-layout,td-layout-nav-listandtd-layout-manage-listwe removed the toggle button from the component and created a few toggle directives so developers can pick and choose how, what and when to add themWhat's included?
[tdLayoutToggle],[tdLayoutNavListToggle]and[tdLayoutManageListToggle]directives.td-layout-nav-listandtd-layout-manage-listin favor of these directives.e.g.
AND
md-toolbarfromtd-layout-manage-listto make it more flexible.e.g.
td-layoutintd-layout-navbefore we needed to check if
td-layout-navwas a child component of anytd-layoutwrapper. now we will remove that dependency all together and the menu button in favor of a[td-menu-button]placeholder so users can add their own button and add[tdLayoutToggle]or their own sidenav.e.g.
OR
The purpose of all this is to make layouts more flexible to allow this sort of thing:
Test Steps
ng serveGeneral Tests for Every PR
ng serve --aotstill works.npm run lintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.Screenshots or link to CodePen/Plunker/JSfiddle