chore(): update documentation with the way to use media.broadcast (closes #684)#685
Merged
Merged
Conversation
…h layouts in ngAfterViewInit angular is more restrictive now and complains if we dont excplicitly call a change detection cycle when changing any input via a life hook cycle such as ngAfterViewInit and ngAfterContentInit.. this happens because the change detections have finished by then, so if you must change anything at that point, you need to call explicitly for a new change detection cycle via `detectChanges`
emoralesb05
added a commit
to Teradata/vantage-ui-template
that referenced
this pull request
Jun 10, 2017
emoralesb05
added a commit
to Teradata/vantage-ui-template
that referenced
this pull request
Jun 10, 2017
* chore(): update quickstar with proper media.broadcast usage reference Teradata/covalent#685 * fix(): ninja remove version from package.json
emoralesb05
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
angular is more restrictive now and complains if we dont explicitly call a change detection cycle when changing any input via a life hook cycle such as
ngAfterViewInitandngAfterContentInit..this happens because the change detections have finished by then, so if you must change anything at that point, you need to call explicitly for a new change detection cycle via
detectChanges#684
Test Steps
nav-listandmanage-listreferencing how to use media in the html example comments.General Tests for Every PR
ng serve --aotstill works.npm run lintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.