Dialect methods implementation#9
Merged
sandan merged 5 commits intoTeradata:masterfrom Aug 4, 2016
mrbungie:feature/complete_dialect_iml
Merged
Dialect methods implementation#9sandan merged 5 commits intoTeradata:masterfrom mrbungie:feature/complete_dialect_iml
sandan merged 5 commits intoTeradata:masterfrom
mrbungie:feature/complete_dialect_iml
Conversation
| # U for Unique | ||
| res = connection.execute(stmt, schema=schema, table=table_name, indextype='U').fetchall() | ||
|
|
||
| def grouper(fk_row): |
Member
There was a problem hiding this comment.
grouper never gets used in get_unique_constraints
| 'name': fk_row.IndexName, | ||
| } | ||
|
|
||
| unique_constraints = list() |
Member
There was a problem hiding this comment.
Ideally we'd like to push as much of the SQL computation to the database so processing is kept simple. I presume that is what your TODO comments are referring to in get_foreign_keys and get_indexes.
This is a good implementation for now. Thanks!
Author
There was a problem hiding this comment.
Yes that's the reason of those TODOs.
Glad you appreciated it! I will continue pushing PRs as long as I find something I can add/fix/improve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2. With this the dialect has enough functionality to be used with Airbnb's Caravel.