feat: ask ModuleManager to load classpath modules #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
keturn
commented
Mar 4, 2021
|
|
||
| @Override | ||
| public void beforeAll(ExtensionContext context) throws Exception { | ||
| System.setProperty(ModuleManager.LOAD_CLASSPATH_MODULES_PROPERTY, "true"); |
Contributor
Author
There was a problem hiding this comment.
This is super sloppy: setting a global property in beforeAll and then never restoring it to its previous state.
but I'm tired and I rationalized it by telling myself that I don't think there are other test cases that will use a ModuleManager in the same process as an MTE test.
if there's a handy JUnit way to manage this, let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of MovingBlocks/Terasology#4543 ModuleManager no longer does this by default, but without it MTE does not know where to find the dependencies of the module under test.
Supersedes #41