Skip to content

feat: ask ModuleManager to load classpath modules #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2021
Merged

feat: ask ModuleManager to load classpath modules #43

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ed14e8
feat: Ask ModuleManager to load classpath modules.
keturn Mar 4, 2021
897cf32
Merge remote-tracking branch 'origin/develop' into feat/use-classpath…
keturn Mar 7, 2021
1db7984
Merge remote-tracking branch 'origin/develop' into feat/use-classpath…
keturn Mar 10, 2021
f4791eb
fixup! Merge remote-tracking branch 'origin/develop' into feat/use-cl…
keturn Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/terasology/moduletestingenvironment/MTEExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import org.junit.jupiter.api.extension.TestInstancePostProcessor;
import org.opentest4j.MultipleFailuresError;
import org.slf4j.LoggerFactory;
import org.terasology.engine.core.module.ModuleManager;
import org.terasology.moduletestingenvironment.extension.Dependencies;
import org.terasology.moduletestingenvironment.extension.UseWorldGenerator;
import org.terasology.engine.registry.In;
Expand Down Expand Up @@ -65,6 +66,8 @@ public void afterAll(ExtensionContext context) throws Exception {

@Override
public void beforeAll(ExtensionContext context) throws Exception {
System.setProperty(ModuleManager.LOAD_CLASSPATH_MODULES_PROPERTY, "true");
Copy link
Contributor Author

@keturn keturn Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super sloppy: setting a global property in beforeAll and then never restoring it to its previous state.

but I'm tired and I rationalized it by telling myself that I don't think there are other test cases that will use a ModuleManager in the same process as an MTE test.

if there's a handy JUnit way to manage this, let me know.


if (context.getRequiredTestClass().isAnnotationPresent(Nested.class)) {
// nested classes get set up in the parent
ModuleTestingHelper parentHelper = helperContexts.get(context.getRequiredTestClass().getEnclosingClass());
Expand Down