Issue 133 new wizard wrong dimensions on creation #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version
updates for multidex
Terence-D
deleted the
issue-133-new_wizard_wrong_dimensions_on_creation
branch
Terence-D
added a commit
that referenced
this pull request
Dec 8, 2020
* Unit test fixes (#130) * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart added several unit tests to launcherBloc.dart * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart added several unit tests to launcherBloc.dart * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart * Update FUNDING.yml * Issue 128 new screen wizard (#132) * some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version * Issue 133 new wizard wrong dimensions on creation (#135) * Issue 128 new screen wizard (#132) (#134) * some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version * fixes for handling screen rotation on new wizard updates for multidex * ran flutter upgrade
Terence-D
added a commit
that referenced
this pull request
Dec 8, 2020
* Unit test fixes (#130) * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart added several unit tests to launcherBloc.dart * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart added several unit tests to launcherBloc.dart * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart * Update FUNDING.yml * Issue 128 new screen wizard (#132) * some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version * Issue 133 new wizard wrong dimensions on creation (#135) * Issue 128 new screen wizard (#132) (#134) * some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version * fixes for handling screen rotation on new wizard updates for multidex * ran flutter upgrade * updates to http handling * udpates to gradle * updates to flutter * added version check and loading window in case of timeouts * undoing change to get it working on build server * reverting gradle to a more stable flutter compatible version * updated release notes * fixes related to gradle, flutter, and android 11 * improved handling if server is too new fixed bugs if invalid password entered etc Fixed links to new server project home
Terence-D
added a commit
that referenced
this pull request
Dec 30, 2020
* Issue 139 update network code to support server 2 0 (#142) * Unit test fixes (#130) * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart added several unit tests to launcherBloc.dart * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart added several unit tests to launcherBloc.dart * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart * Update FUNDING.yml * Issue 128 new screen wizard (#132) * some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version * Issue 133 new wizard wrong dimensions on creation (#135) * Issue 128 new screen wizard (#132) (#134) * some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version * fixes for handling screen rotation on new wizard updates for multidex * ran flutter upgrade * updates to http handling * udpates to gradle * updates to flutter * added version check and loading window in case of timeouts * undoing change to get it working on build server * reverting gradle to a more stable flutter compatible version * updated release notes * fixes related to gradle, flutter, and android 11 * improved handling if server is too new fixed bugs if invalid password entered etc Fixed links to new server project home * Bug fixes (#143) * added optional screen resizing when trying to play * added vscode launch json fixed starting wrong screen formatting that better matches darts opinionated views. * Bug fixes (#144) * added optional screen resizing when trying to play * added vscode launch json fixed starting wrong screen formatting that better matches darts opinionated views. * added some buffer to the screen dimension check * Bug fixes (#145) * added optional screen resizing when trying to play * added vscode launch json fixed starting wrong screen formatting that better matches darts opinionated views. * added some buffer to the screen dimension check * better handling of version handling * Bug fixes (#147) * added optional screen resizing when trying to play * added vscode launch json fixed starting wrong screen formatting that better matches darts opinionated views. * added some buffer to the screen dimension check * better handling of version handling * fixed code accidently overwritten
Terence-D
added a commit
that referenced
this pull request
Dec 31, 2020
* Issue 139 update network code to support server 2 0 (#142) * Unit test fixes (#130) * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart added several unit tests to launcherBloc.dart * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart added several unit tests to launcherBloc.dart * cleaned up launcherBloc.dart with comments / returns added unit tests - launcherBloc_test.dart * Update FUNDING.yml * Issue 128 new screen wizard (#132) * some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version * Issue 133 new wizard wrong dimensions on creation (#135) * Issue 128 new screen wizard (#132) (#134) * some refactoring / fixing of hard coded import paths implementing the new screen wizard has started * initial work on building UI for new screen wizard * working on building UI for general * orientation button updates * staring on layout widget put in example table (to be removed) * built layout widget * removed unnecessary code * temporarily holding off on building the control design, will need to wait until i redo the "game" view * cleaning up unused translation code setting up for wizard control view * finalized translations for layoutWidget.dart * implemented basic code - but crashes due to not setting button/switch/background details (at least) * added default controls code compiles, sort of runs. need to work on positioning and importing of default values from native * refreshes view after creating new screen properly lays out buttons * uses a default image, wrong, but better than nothing bug fixes around null * fixed importing defaults tweaked margins on new * removed restrictions on requiring text/command for controls added separate text control for switches * customizable screen dimensions * fixed unit tests * removed comment * update version * fixes for handling screen rotation on new wizard updates for multidex * ran flutter upgrade * updates to http handling * udpates to gradle * updates to flutter * added version check and loading window in case of timeouts * undoing change to get it working on build server * reverting gradle to a more stable flutter compatible version * updated release notes * fixes related to gradle, flutter, and android 11 * improved handling if server is too new fixed bugs if invalid password entered etc Fixed links to new server project home * Bug fixes (#143) * added optional screen resizing when trying to play * added vscode launch json fixed starting wrong screen formatting that better matches darts opinionated views. * Bug fixes (#144) * added optional screen resizing when trying to play * added vscode launch json fixed starting wrong screen formatting that better matches darts opinionated views. * added some buffer to the screen dimension check * Bug fixes (#145) * added optional screen resizing when trying to play * added vscode launch json fixed starting wrong screen formatting that better matches darts opinionated views. * added some buffer to the screen dimension check * better handling of version handling * Bug fixes (#147) * added optional screen resizing when trying to play * added vscode launch json fixed starting wrong screen formatting that better matches darts opinionated views. * added some buffer to the screen dimension check * better handling of version handling * fixed code accidently overwritten * Update FUNDING.yml * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes to new screen wizards orientation