Skip to content

fix: when decoding pem files, handle lines being terminated by CRLF as well as just LF #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicajilau merged 1 commit into from
Apr 12, 2026
Merged

fix: when decoding pem files, handle lines being terminated by CRLF as well as just LF #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/ssh_pem.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class SSHPem {
static const _pemEnd = '-----';

factory SSHPem.decode(String pem) {
final lines = pem.trim().split("\n");
final lines = pem.trim().split(RegExp(r"\r?\n"));
final header = lines.first;
final footer = lines.last;

Expand Down
12 changes: 12 additions & 0 deletions test/src/ssh_pem_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,18 @@ g1O5wsVZjzX9a6/Zo4ikAAAAGWpmb3V0dHNAVVNBSkZPVVRUU00ubG9jYWwBAgME
expect(pem.type, 'OPENSSH PRIVATE KEY');
});

test('SSHPem.decode works with crlf not just lf', () {
final pem = SSHPem.decode('-----BEGIN OPENSSH PRIVATE KEY-----\r\n'
'b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAAAMwAAAAtzc2gtZW\r\n'
'QyNTUxOQAAACBZnnnYZjFQ7Zt0gMyJ2YYmDINTucLFWY81/Wuv2aOIpAAAAKBQ6gOSUOoD\r\n'
'kgAAAAtzc2gtZWQyNTUxOQAAACBZnnnYZjFQ7Zt0gMyJ2YYmDINTucLFWY81/Wuv2aOIpA\r\n'
'AAAEAP8fq0hjlR3jhL7pg+26PSaMiC1V/RrinVbo/4eBMRNFmeedhmMVDtm3SAzInZhiYM\r\n'
'g1O5wsVZjzX9a6/Zo4ikAAAAGWpmb3V0dHNAVVNBSkZPVVRUU00ubG9jYWwBAgME\r\n'
'-----END OPENSSH PRIVATE KEY-----\r\n');

expect(pem.type, 'OPENSSH PRIVATE KEY');
});

test('SSHPem.decode can parse header', () {
final pem = SSHPem.decode(r'''-----BEGIN OPENSSH PRIVATE KEY-----
Header1: Value1
Expand Down
Loading