Handle update checker failures gracefully#1016
Open
Zaxoosh wants to merge 1 commit intoTerraformersMC:26.1from
Open
Handle update checker failures gracefully#1016Zaxoosh wants to merge 1 commit intoTerraformersMC:26.1from
Zaxoosh wants to merge 1 commit intoTerraformersMC:26.1from
Conversation
Merged
Contributor
|
Very good. Thank you for this. |
Author
|
All good, always happy to help out! |
Contributor
|
So regarding #972 (comment) Okay so I missed a few returns and exceptions in #972 I think putting a ExecutorService executor = Executors.newThreadPerTaskExecutor(new UpdateCheckerThreadFactory());
try {
// Do stuff
} finally {
executor.shutdown();
}should fix this in a much cleaner way instead of putting into every if or catch block ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
#1011's log shows a timeout followed by a malformed/truncated Modrinth JSON response. The parser exception escaped through
Future.get(), andcheckForUpdates0rethrew theExecutionExceptionas aRuntimeException, which crashed Minecraft.Validation
./gradlew.bat buildFixes #1011