Update to snapshot 25w09a & Improve Rendering Code#831
Merged
Prospector merged 8 commits intoTerraformersMC:1.21.5from Mar 11, 2025
lowercasebtw:1.21.5
Merged
Update to snapshot 25w09a & Improve Rendering Code#831Prospector merged 8 commits intoTerraformersMC:1.21.5from lowercasebtw:1.21.5
Prospector merged 8 commits intoTerraformersMC:1.21.5from
lowercasebtw:1.21.5
Conversation
lowercasebtw
changed the title
Prospector
requested changes
Mar 9, 2025
Member
Prospector
left a comment
Prospector
left a comment
There was a problem hiding this comment.
This PR also seems to include a reformatting. I don't particularly mind, but it'd be great if you could include an editorconfig file or something so that we don't keep reformatting to a new person's formatter settings each time someone new is trying to contribute.
Contributor
Author
|
About the editor config thing, how would I do that? |
Member
In IntelliJ at least you can export it here in settings under Code Style, and then it just goes in the root of the repo. Though, I guess I'm not 100% all the things that can be controlled by this. so not entirely sure if it'll work
|
Contributor
Author
|
mk |
Contributor
Author
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved how the rendering code was to use modern uses of RenderTypes and used VertexBuffer how it was before (in BufferUploader), and updated to 25w08a.
Also upgraded Loom, Gradle, & Fabric API.