fix: rendering methods for RC1#840
Merged
Prospector merged 6 commits intoTerraformersMC:1.21.5from Mar 25, 2025
Merged
Conversation
fix check_build.yml
v4 sertup-java
TheBossMagnus
suggested changes
Mar 24, 2025
TheBossMagnus
left a comment
TheBossMagnus
left a comment
There was a problem hiding this comment.
you need to change the java version (from 17 to 21) in the upload artifact section of the workflow, right now no jar is uploaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix rendering workflow, Bump PAPI from my work on PAPI for 1.21.5 & minor version update for check_build.yml
Did you guys want to use Zulu or Termurin for the check_build though ? Just change the distro variable. ubuntu 20.04 / 22.04 is deprecated LTS now.