Remove mousescroll override in modsscreen#921
Merged
gniftygnome merged 1 commit intoTerraformersMC:1.21.11from Nov 12, 2025
Merged
Remove mousescroll override in modsscreen#921gniftygnome merged 1 commit intoTerraformersMC:1.21.11from
gniftygnome merged 1 commit intoTerraformersMC:1.21.11from
Conversation
Contributor
|
Yes. The vanilla implementation calls it for all hovered elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this override isn't needed as it is implemented in net.minecraft.client.gui.ParentElement and it tries to mousescroll over any selectable child, which implements it and is being hovered over.
i recently added a feature to my mod, which makes you be able to scroll in (most) text input field widgets. however, when i tried to scroll in the text field in the modmenu screen, it didn't work. i decided to dig deeper and found this solution.
the issue is very minor and i don't think it will cause as many problems but i had thought of one: users of my mod might change some options in my mod and then try it out on the mods screen search bar and see that it doesn't work and then probably blame me... i doubt that this will happen often, but i just made this pull request to fix this