Skip to content

1757 fixes#496

Merged
soyarsauce merged 4 commits into1757-mobx-tm-new-routingfrom
1757-fixes
Oct 28, 2020
Merged

1757 fixes#496
soyarsauce merged 4 commits into1757-mobx-tm-new-routingfrom
1757-fixes

Conversation

@na9da
Copy link
Copy Markdown
Contributor

@na9da na9da commented Oct 28, 2020

Contains the following fixes to pre-rendering:

  • Captures all CSS styling including those generated by styled-components
  • Directs requests to /proxyabledomains and /proxy to locally running server.
  • Hides errors or other modals from the rendered output.

@soyarsauce
Copy link
Copy Markdown
Contributor

You have no idea how pleased this makes me @na9da - bloody awesome work on addressing the styling issue in v8 for this.

I've made a small tweak to use webpack, even though it shouldn't be cause for problem (from doing it in TerriaMap), simply to cover https://github.com/TerriaJS/terriajs/blob/8d5ef29c5fa2e758aebad313024d460a34817a68/buildprocess/runWebpack.js#L4-L5. Just as I know this particular config has worked for terrace

@soyarsauce
Copy link
Copy Markdown
Contributor

Also, while testing it occurred to me that disclaimer is no longer fixed, so I've raised an issue for that here

@soyarsauce
Copy link
Copy Markdown
Contributor

Will let CI etc checks via target branch 1757-mobx-tm-new-routing

@soyarsauce soyarsauce merged commit 112efc3 into 1757-mobx-tm-new-routing Oct 28, 2020
@soyarsauce soyarsauce deleted the 1757-fixes branch October 28, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants