1757 fixes#496
Merged
soyarsauce merged 4 commits into1757-mobx-tm-new-routingfrom Oct 28, 2020
Merged
Conversation
2 tasks
Contributor
|
You have no idea how pleased this makes me @na9da - bloody awesome work on addressing the styling issue in v8 for this. I've made a small tweak to use webpack, even though it shouldn't be cause for problem (from doing it in TerriaMap), simply to cover https://github.com/TerriaJS/terriajs/blob/8d5ef29c5fa2e758aebad313024d460a34817a68/buildprocess/runWebpack.js#L4-L5. Just as I know this particular config has worked for terrace |
soyarsauce
approved these changes
Oct 28, 2020
Contributor
|
Will let CI etc checks via target branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains the following fixes to pre-rendering:
styled-components/proxyabledomainsand/proxyto locally running server.